Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Union validation (#230) #233

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Add Union validation (#230) #233

merged 1 commit into from
Feb 23, 2020

Conversation

palanga
Copy link
Contributor

@palanga palanga commented Feb 22, 2020 •
edited by ghostdogpr
Loading

Fixes #230

@palanga palanga requested a review from ghostdogpr February 22, 2020 19:51
ghostdogpr
ghostdogpr reviewed Feb 22, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run fmt in sbt? That’ll format the code and the CI can be green.

Looks good except that! 👍

core/src/main/scala/caliban/CalibanError.scala Show resolved Hide resolved
@palanga
Copy link
Contributor Author

palanga commented Feb 23, 2020

Done. Thank you.

ghostdogpr
ghostdogpr approved these changes Feb 23, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution! 🙏

@ghostdogpr ghostdogpr merged commit 69f0ca6 into ghostdogpr:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema validation: unions
2 participants
@palanga @ghostdogpr